Quote.Update BPM checking for required fields

Epicor ERP 10
, , ,
1

I’m trying to reduce the frequency of clicking through this BL exception when creating New lines.
We currently have the below as a pre-proc BPM on Quote.Update. The users end up having to click through this exception at least once or twice while trying to enter revision, quantities, and sales category. There are no conditions or anything added in the designer, it’s just Start > Execute Code.
Thanks all.

//Define Error Message variable.
string cErrMsg = string.Empty;

//Define additional table references.
Erp.Tables.Part Part;

foreach (var ttQuoteDtl_iterator in (from ttQuoteDtl_Row in ttQuoteDtl
		where ttQuoteDtl_Row.Company == Session.CompanyID
		&& string.Equals(ttQuoteDtl_Row.RowMod, IceRow.ROWSTATE_UPDATED, StringComparison.OrdinalIgnoreCase)
//		&& string.Equals(ttQuoteDtl_Row.RowMod, IceRow.ROWSTATE_ADDED, StringComparison.OrdinalIgnoreCase) 
//		|| string.Equals(ttQuoteDtl_Row.RowMod, IceRow.ROWSTATE_UPDATED, StringComparison.OrdinalIgnoreCase)
		select ttQuoteDtl_Row))
{
		var ttQuoteDtlRow = ttQuoteDtl_iterator;
		if (String.IsNullOrEmpty(ttQuoteDtlRow.RevisionNum))
		{
				cErrMsg = cErrMsg + "Missing Part Revision.\n";
		}
		if (String.IsNullOrEmpty(ttQuoteDtlRow.SalesCatID))
		{
				cErrMsg = cErrMsg + "Missing Sales Category.\n";
		}
				if (String.IsNullOrEmpty(ttQuoteDtlRow.ProdCode))
		{
				cErrMsg = cErrMsg + "Missing Product Group.\n";
		}
		if (ttQuoteDtlRow.SellingExpectedQty == 0)
		{
				cErrMsg = cErrMsg + "Missing Expected Qty.\n";
		}
}
if (!String.IsNullOrEmpty(cErrMsg))
{
		cErrMsg = cErrMsg + "\n[BPM Quote.Update Check_ReqFields]\n";
		CallContext.Current.ExceptionManager.AddBLException(cErrMsg);
}
2

This is a very common issue when people try to make fields “required”. I recommend always asking the question: required to do what?

With a BPM like this on Quote.Update, you’re saying that the fields are required before a new record can even be saved. That’s probably a bit much.

I like to fire BPMs on something like when the Quoted checkbox is checked… don’t let it get checked if any of the “required” fields are blank or null. That (depending on your processes) still prevents processing a Quote with missing data, and it gives the user some breathing room before Epicor tries jumping down their throats…

1 Like
3

Quoted seems to get checked programmatically during the Task set, but that still sounds like a fantastic idea. Thank you for the hint.

4

you can also reduce the code size down by doing some tweaks.
One thing that you should not do is iterate through the data before it is completely selected… that is why I did the first line to query the data from the tt record, which brings all the record(S) into your local ttqDtl_Rows. Then you iterate through those.
I also changed this to a lambda query which is much shorter, EXCEPT, I look for the possible errors in the query, so this should speed up the process since it doesn’t have to iterate through all the modified records to check for errors. If something is found, then there IS an error.

//Define Error Message variable.
string cErrMsg = string.Empty;
string messageString = "";

//query the table... only select the problem records.
var ttqDtl_Rows = ttQuoteDtl.Where(x=>
	x.Company == Session.CompanyID &&
	x.RowMod == "U" &&
	(	x.RevisionNum == "" ||
		x.SalesCatID == "" ||
		x.ProdCode == "" ||
		x.SellingExpectedQty == "")
	);
if (!ttqDtl_Rows == null) {
	//something was found... lets process it
	foreach (var ttqDtl in ttqDtlR_Rows) {
		messageString = ""
		messageString += (ttqDtl.RevisionNum == "") ? "" : "Missing Part Revision, ";
		messageString += (ttqDtl.SalesCatID == "") ? "" : "Missing Sales Category, ";
		messageString += (ttqDtl.ProdCode == "") ? "" : "Missing Product Group, ";
		messageString += (ttqDtl.SellingExpectedQty == "") ? "" : "Missing Expected Qty, ";
		cErrMsg = (messageString == "") ? "" : $"Quote Line: {ttqDtl.QuoteLine} Errors:{messageString}\n"
	}
	if (!String.IsNullOrEmpty(cErrMsg))
	{
		cErrMsg = cErrMsg + "\n[BPM Quote.Update Check_ReqFields]\n";
		CallContext.Current.ExceptionManager.AddBLException(cErrMsg);
	}
}
3 Likes